engine: store manifest enabled state in ManifestState #5396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few places in the engine (the ones changed in this PR) need to know if a Manifest is enabled and were doing this by checking UIResource.DisableStatus.
As part of the tilt args / enable/disable work, I'm changing things so that all manifests are considered disabled when created and then become enabled when the api objects shake out. For the engine bits in this PR, that'd mean tests need to ensure enabled resources have both a UIResource and a ConfigMap.
It also felt kind of weird that, e.g., BuildController was coupled to UIResource.
This almost certainly isn't how we want to do this long term, but it seems like a better interim solution than what's already there and will make some upcoming changes less invasive.