Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: tweak event display #5410

Merged
merged 1 commit into from
Jan 25, 2022
Merged

store: tweak event display #5410

merged 1 commit into from
Jan 25, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Jan 25, 2022

Hello @nicksieger, @milas,

Please review the following commits I made in branch nicks/event:

3a9664c (2022-01-25 16:07:24 -0500)
store: tweak event display

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks
Copy link
Member Author

nicks commented Jan 25, 2022

events now print like this:

[event: pod nicks-env] Container image "localhost:45361/ephctrl-dind:tilt-830bc785828eeaf4" already present on machine
[event: pod nicks-env] Container image "localhost:45361/ephctrl-tilt-upper:tilt-fe2da4a8e4a4d718" already present on machine

which seems more consistent with how other stuff is displayed in tilt

@nicks nicks merged commit d2c5572 into master Jan 25, 2022
@nicks nicks deleted the nicks/event branch January 25, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants