web: add expand-all and collapse-all buttons #5611
Conversation
|
This pull request has been linked to Shortcut Story #13280: As user, I see more view options in Table View [Design WIP]. |
|
|
nicks
force-pushed
the
nicks/ch13280
branch
4 times, most recently
from
100f823
to
f6dd374
Compare
| function collapseAll(groupNames: string[]) { | ||
| let newState: GroupsState = {} | ||
| groupNames.forEach((group) => (newState[group] = { expanded: false })) | ||
| setGroups(newState) |
There was a problem hiding this comment.
this is a minor detail / edge case that i'm not sure is worth addressing, but i'll mention it anyways! when disabled resources are hidden, label groups with only disabled resources will be reset to expanded when collapseAll is invoked.
There was a problem hiding this comment.
oh boy it gets more complicated than that!
- if you click "collapse all", and then create new groups, do they default to expanded or collapsed?
- if you remove a collapsed group, click "expand all", and then bring the group back, does it default to expanded or collapsed?
i don't think there's an obvious right answer here...i like how the existing model encourages a default state of "expanded" when there are any open questions.
will leave some comments on this.
|
oh, i didn't realize that we were planning to add this to the sidebar too! ya, let's do that in a follow-up. |
|
also - i hope i didn't step on your toes! didn't realize there was a duplicate ticket 😬 |
|
Old duplicate ticket (ch12977) is largely my fault! I assigned it to myself with the intent of doing it a bit back but ended up never getting to it, so no worries, and glad this made it in regardless! |
|
This pull request has been linked to Shortcut Story #12977: Nice-to-have: Add expand and collapse groups buttons to both views. |
Hello @landism, @lizzthabet,
Please review the following commits I made in branch nicks/ch13280:
7d6cdc6 (2022-03-21 18:14:18 -0400)
web: add expand-all and collapse-all buttons
Code review reminders, by giving a LGTM you attest that: