cluster: monitor K8s livez/readyz after initialization #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After initializing a connection, start a monitor goroutine to poll the `/livez` and `/readyz` endpoints of the cluster and update the Tilt `Cluster` object status accordingly. Additionally, if the client cannot be initialized in the first place, the reconciler will requeue itself in the future and attempt re-initialization.
nicksieger
approved these changes
Mar 23, 2022
milas
commented
Mar 30, 2022
Comment on lines
+560
to
+565
| var annotations map[string]string | ||
| if tlr.FeatureFlags[feature.ClusterRefresh] { | ||
| annotations = map[string]string{ | ||
| "features.tilt.dev/cluster-refresh": "true", | ||
| } | ||
| } |
There was a problem hiding this comment.
This felt like a reasonably clean way to propagate feature flag information to an individual resource, and there's sorta precedent here because we conditionally create disable buttons in a sibling function based on feature flags
|
Reason I'd been holding off on merging this is because of the issues it exposes that I mentioned during demo in company meeting. Requested a new review (cc @nicksieger) because I added a feature flag to gate the problematic part of the functionality (existing logic remains as-is), so we can continue to address the underlying issues safely |
nicksieger
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After initializing a connection, start a monitor goroutine to
poll the
/livezand/readyzendpoints of the cluster andupdate the Tilt
Clusterobject status accordingly.Additionally, if the client cannot be initialized in the first
place, the reconciler will requeue itself in the future and
attempt re-initialization.