Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiltfile: local: add stdin param #5641

Merged
merged 3 commits into from Apr 1, 2022
Merged

tiltfile: local: add stdin param #5641

merged 3 commits into from Apr 1, 2022

Conversation

landism
Copy link
Member

@landism landism commented Mar 29, 2022

This is mostly to make it easier to get a starlark variable into a command (e.g., kubectl apply -f - or cat > foo.yaml).

This is currently possible by escaping the var into the command line and piping, but 1) escaping feels finicky and 2) that risks hitting ARG_MAX.

@landism landism requested review from nicks and milas March 29, 2022 21:50
@landism landism changed the title tiltfile: add stdin param tiltfile: local: add stdin param Mar 29, 2022
milas
milas approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree it's probably advisable to distinguish None from "" (or provide some sort of special built-in value like DUMMY_STDIN), but otherwise 👍

@landism
Copy link
Member Author

landism commented Mar 30, 2022

redid it using None instead

and generics!

nicksieger
nicksieger approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@landism landism merged commit 1ee7d4f into master Apr 1, 2022
@landism landism deleted the matt/local_stdin branch April 1, 2022 14:53
@lizzthabet lizzthabet mentioned this pull request Apr 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicksieger nicksieger nicksieger approved these changes

@milas milas milas approved these changes

@nicks nicks Awaiting requested review from nicks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@landism @nicksieger @nicks @milas