Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildcontrol: pass in a cluster rather than injecting a default cluster #5645

Merged
merged 1 commit into from Mar 31, 2022
Merged

buildcontrol: pass in a cluster rather than injecting a default cluster #5645

merged 1 commit into from Mar 31, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 31, 2022

Hello @milas,

Please review the following commits I made in branch nicks/cluster5:

5492a4b (2022-03-31 13:25:00 -0400)
buildcontrol: pass in a cluster rather than injecting a default cluster

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from milas March 31, 2022 17:25
milas
milas approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wahoo!

@nicks nicks merged commit 00745ff into master Mar 31, 2022
@nicks nicks deleted the nicks/cluster5 branch March 31, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicks @milas