tiltfile: properly model filewatches shared across multiple images #5648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landism
approved these changes
Apr 1, 2022
| @@ -531,6 +563,11 @@ func toImageMapObjects(tlr *tiltfile.TiltfileLoadResult, disableSources disableS | |||
| } | |||
|
|
|||
| name := iTarget.ImageMapName() | |||
| _, ok := result[name] | |||
| if ok { | |||
| continue | |||
There was a problem hiding this comment.
Do we not need to merge disable sources here as well? (or I guess this PR is about filewatches anyway)
Comment on lines
571
to
572
| // Note that an ImageMap might be in more than one Manifest, so we | ||
| // can't annotate them to a particular manifest. |
There was a problem hiding this comment.
unrelated to this PR, feel free to ignore - it looks like a few lines down we are annotating them to a particular manifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism, @nicksieger,
Please review the following commits I made in branch nicks/every2:
f289f7a (2022-03-31 17:41:50 -0400)
tiltfile: properly model filewatches shared across multiple images
fixes #5621
Code review reminders, by giving a LGTM you attest that: