fix: fix typos using typos #6158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/crate-ci/typos ```console $ typos --version typos-cli 1.15.7 ``` _typos.toml ```toml [default.extend-words] servantes = "servantes" Servantes = "Servantes" O_WRONLY = "O_WRONLY" WRONLY = "WRONLY" whosAGoodBoy = "whosAGoodBoy" supercede = "supercede" dne = "dne" Anser = "Anser" [default.extend-identifiers] whosAGoodBoy = "whosAGoodBoy" whosAGoodCat = "whosAGoodCat" KubernetesApplys = "KubernetesApplys" KubernetesDiscoverys = "KubernetesDiscoverys" ANDed = "ANDed" TestEncodeYAMLNonYAMLable = "TestEncodeYAMLNonYAMLable" [files] extend-exclude = ["vendor/*", "pkg/apis/core/v1alpha1/generated.pb.go", "pkg/snapshot/testdata/snapshot.json", "pkg/snapshot/testdata/snapshot_new.json", "internal/hud/webview/testdata/snapshot.json", "pkg/apis/core/v1alpha1/generated.proto"] ``` ```console $ typos --no-check-filenames -w ``` Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
|
I think the problem is that some of these aren't typos in tilt - they're typos in upstream projects, and so the code in tilt needs to use the same spelling |
|
Thank you for your comment. |
nicks
reviewed
Jun 29, 2023
internal/build/docker_builder.go
Outdated
| // nolint | ||
| regexp.MustCompile("(executor failed running.*): runc did not terminate sucessfully"), // sucessfully (sic) | ||
| regexp.MustCompile("(executor failed running.*): runc did not terminate successfully"), // successfully (sic) |
There was a problem hiding this comment.
i think this one needs to be reverted, because the typo is upstream (that's why it's marked sic)
There was a problem hiding this comment.
Oh, I see. Thank you for pointing it out.
I reverted. f800b65
suzuki-shunsuke
added a commit
to suzuki-shunsuke/tilt
that referenced
this pull request
Jun 30, 2023
tilt-dev#6158 (comment) > i think this one needs to be reverted, because the typo is upstream Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
suzuki-shunsuke
added a commit
to suzuki-shunsuke/tilt
that referenced
this pull request
Jun 30, 2023
tilt-dev#6158 (comment) > i think this one needs to be reverted, because the typo is upstream Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
https://github.com/tilt-dev/tilt/pull/6158/files#r1246768000 > i think this one needs to be reverted, because the typo is upstream (that's why it's marked sic) Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos using typos.
https://github.com/crate-ci/typos
_typos.toml
$ typos --no-check-filenames -wAnd I fixed some typos manually.