New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add 'tilt alpha shell' for creating a shell into a container #6286
Conversation
cc @joe0BAB - in particular, how this interacts with 'kubectl shell' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
internal/cli/shell.go
Outdated
- kubectl shell | ||
- dld shell | ||
- docker exec -it <container> bash | ||
- docker exec -it <container> sh`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be a fallback to kubectl debug
also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think kubectl debug
is for a different use-case? i.e., it's more for "i'm debugging the infra and want to ssh to the Node where this pod lives and check the firewall rules" rather than tilt's "i'm debugging the container and want to poke around on its filesystem"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's interesting you thought that. You can attach to a node, but you can do the same with a pod. It's currently a bit short of functionality of enabling what 'kubectl shell' does on the client side, there is an open PR to add a privileged profile.
designed to interoperate with the new `kubectl shell`, but fallback to kubectl exec if the container supports it. Future work: - use with Docker Compose - add a terminal to the tilt UI Signed-off-by: Nick Santos <nick.santos@docker.com>
i put this under |
designed to interoperate with the new
kubectl shell
, but fallback to kubectl exec if the container supports it.Future work: