Update addon for FastBoot 1.0 #112
Conversation
| } | ||
|
|
||
| if (debugMode) { | ||
| app.import('vendor/plupload/moxie.js'); |
There was a problem hiding this comment.
@kratiahuja Can I ask why this is changed to the vendor/ folder instead of bower_components folder? Is this something to do with app.import specifically? I've noticed in a few addons that vendor and node_modules/bower_components are almost interchangeable? Does Ember CLI treat them all the same during build or something?
There was a problem hiding this comment.
This is the path to your file. Since we needed to wrap the file before importing it, we did it in treeForVendor and merged it there so it will be in the vendor trees.
There was a problem hiding this comment.
If you're going to change the directory, could you also change Moxie.swf?
There was a problem hiding this comment.
@tim-evans happy to change, but curious to understand why you want to chain for Moxie.swf too since that can be imported via bower.
There was a problem hiding this comment.
Consistency, but it doesn't matter :)
This change wraps the browser specific libraries with if (typeof FastBoot === 'undefined') {...} check so that they are eval'd and run in browser but only eval'd and skipped in Node.
This prepares the addon for the upcoming FastBoot 1.0. See ember-fastboot/ember-cli-fastboot#387
cc: @tim-evans