Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biblebook Tags for numbered Books not working #153

Closed
fre98fi opened this issue Nov 3, 2023 · 7 comments
Closed

Biblebook Tags for numbered Books not working #153

fre98fi opened this issue Nov 3, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@fre98fi
Copy link

fre98fi commented Nov 3, 2023

Describe the bug
When a numbered book like "2 Corinthians" is referenced and a Book-Tag is generated, the generated Tag looks like "#2 Corinthians". The problem here is that Obsidian will not recognize this as a Tag. It should look like "#2Corinthians".

To Reproduce
Steps to reproduce the behavior:

  1. Activate Book Tags in the Expert Settings
  2. Reference a numbered Book
  3. Look for the used Tags

Expected behavior
Tags should be in the right format to be recognized by Obsidian

What Device Do You Use(please complete the following information):

  • Device: MacBook Pro 14 M1 Pro 2021
  • OS: Sonoma 14.0
  • Obsidian Version 1.4.16
  • Version 2.3.4
@fre98fi fre98fi added the bug Something isn't working label Nov 3, 2023
@tim-hub
Copy link
Owner

tim-hub commented Nov 21, 2023

Thanks for raising this, I didn't notice it. Will have a look

Copy link

stale bot commented Jan 20, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 20, 2024
@tim-hub tim-hub removed the wontfix This will not be worked on label Jan 21, 2024
@yintzgit
Copy link

yintzgit commented Mar 5, 2024

Hi, similar issue in windows11pro: with numbered books (eg Cor, Thess) it is not possible to get the bible text, same with or without tag. Doesnot work in german bible texts (eg Luther, Menge). English works, french works, spanish works.
Regards from Germany,

Copy link

stale bot commented May 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 4, 2024
@tim-hub tim-hub removed the bug Something isn't working label May 5, 2024
@stale stale bot removed the wontfix This will not be worked on label May 5, 2024
@tim-hub tim-hub added the bug Something isn't working label May 5, 2024
@abbasou
Copy link
Contributor

abbasou commented May 12, 2024

Just noticed this as well. Fixed by adding .replace(/ /g, "") to:

bottom += ((_c = this.settings) == null ? void 0 : _c.bookTagging) ? ` #${this.verseReference.bookName

and

bottom += ((_d = this.settings) == null ? void 0 : _d.chapterTagging) ? ` #${this.verseReference.bookName

in get bottom()
Hope that helps.

@abbasou
Copy link
Contributor

abbasou commented May 16, 2024

Pull request submitted to fix this.

@tim-hub
Copy link
Owner

tim-hub commented May 18, 2024

@tim-hub tim-hub closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants