Implemented retry.wrap for #6, also added tests and documentaion #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey kof, sorry for the long delay on this one. Can you please pull the original master and resolve the conflicts and then resubmit the pr? Thank you! |
|
hi, done. P.S: yes, your latency is sensational :) |
| if (!methods) { | ||
| methods = []; | ||
| for (var key in obj) { |
There was a problem hiding this comment.
This should check for typeof key === 'function', so that other properties on the object that are not functions aren't taken as such.
|
Once you correct these few things I'd be happy to merge this! Thank you for your effort! |
|
+1 for merge |
|
Hey @kof did you see my comments above? |
|
Hi @tim-kos. Time has changed. I am not using it actively right now. I would appreciate if someone else takes my commits and implements the changes. |
|
Okay, I'll take it over myself. |
|
This has been implemented in 9446e80 Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.