Laravel 10.x Compatibility

[laravel-shift]

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

• Checkout the l10-compatibility branch
• Review all comments for additional changes
• Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

[laravel-shift]

⚠️ Shift detected a dependency for the laravel/framework. Unless you have a special requirement for depending on the entire Laravel framework, it's recommended to add dependencies for the specific illuminate packages instead.

[laravel-shift]

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/json-api.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "timacdonald/json-api": "dev-l10-compatibility",
    }
}

Finally, run: composer update

[jeffwhansen]

Do we have an eta on laravel 10.x support? Thanks for the awesome package.

[lloricode]

+1

[lloricode]

can not use this while using Model::shouldBeStrict(),

since this is the fix on v1.0.0-beta.3

json-api/src/Concerns/Attributes.php

Line 71 in deb13fa

return Collection::make(property_exists($this, 'attributes') ? $this->attributes : [])

[timacdonald]

Hey folks, 10.0 will drop soon. Just need some time to review.

[timacdonald]

@lloricode interested to know how that breaks things. Can you paste me the error message? It is my understanding that property_exists doesn't invoke anything via magic getters.

[lloricode]

@lloricode interested to know how that breaks things. Can you paste me the error message? It is my understanding that property_exists doesn't invoke anything via magic getters.

Hi, it seems this PR is not updated with your branch, that is why even installing this using laravel-shift repo, will still does not works while using Model::shouldBeStrict()

[lloricode]

@timacdonald

[timacdonald]

Ah, gotcha. Yea, the branch needs to be rebased.

[lloricode]

Ah, gotcha. Yea, the branch needs to be rebased.

thank you

[timacdonald]

This has been tagged.

If you are coming from a 0.x version, please see the upgrade guide.

[jeffwhansen]

Thank you!

…

On Feb 20, 2023, at 1:24 AM, Tim MacDonald ***@***.***> wrote: This has been tagged <https://github.com/timacdonald/json-api/releases/tag/v1.0.0-beta.4>. If you are coming from a 0.x version, please see the upgrade guide <https://github.com/timacdonald/json-api/blob/main/UPGRADE.md>. — Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASWCZ2WY72TD64O3KVDPTTWYMS5LANCNFSM6AAAAAAUOVPAWE>. You are receiving this because you commented.