Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-app-rewire-favicons-plugin #249

Merged
merged 1 commit into from May 23, 2018
Merged

Conversation

RickyCook
Copy link
Contributor

No description provided.

@timarney
Copy link
Owner

I seem to get a 404 on your link

https://github.com/rickycook/react-app-rewire-favicons-plugin

@timarney timarney closed this May 23, 2018
@RickyCook
Copy link
Contributor Author

sorry! i saw this when you posted and forgot about it. would you reopen if i updated the link tomorrow morning?

@timarney timarney reopened this May 23, 2018
@timarney
Copy link
Owner

@RickyCook feel free update and we'll get that merged in.

@RickyCook
Copy link
Contributor Author

helps if i actually create the repo.... should be fixed now :)

@timarney timarney merged commit dfeb0ff into timarney:master May 23, 2018
@RickyCook
Copy link
Contributor Author

thanks!

@timarney
Copy link
Owner

Sure thing - I haven't seen the favicons-webpack-plugin before looks handy.

@RickyCook
Copy link
Contributor Author

it's great!

logo in svg? fine; generates browser favicons in different sizes, along with (many) ios/android images for the "add to home screen" features. it's pretty neat!

@timarney
Copy link
Owner

Nice - you happen to be on twitter? Going to tweet that out.

@RickyCook
Copy link
Contributor Author

i am! thatpandadev... but it's not my plugin; i just wrote the rewire part! :P

@timarney
Copy link
Owner

@RickyCook
Copy link
Contributor Author

oh right! thanks ^.^ so much yay for open source right? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants