Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check if overriden value is primitive value like number or boolean #508

Merged

Conversation

rosieks
Copy link
Contributor

@rosieks rosieks commented Dec 2, 2020

This pull requests fixes issue #507. It adds support for overriding jest configuration with primitive values like number or boolean. As for now it's limited to string, arrays or objects.

@timarney
Copy link
Owner

timarney commented Dec 2, 2020

@dawnmist any thoughts on merging this?

I haven't been keeping from v2 forward.

Copy link
Collaborator

@dawnmist dawnmist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me :)

@timarney
Copy link
Owner

timarney commented Dec 2, 2020

Great thanks - I'll plan to push out a new version on the weekend.

@timarney timarney merged commit a4ee598 into timarney:master Dec 4, 2020
@rosieks rosieks deleted the 507-support-primitive-jest-overrides branch December 7, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants