Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v2 API #131

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Use v2 API #131

merged 4 commits into from
Oct 12, 2022

Conversation

naderabbara
Copy link
Contributor

Replaces the deprecated class and functions. As is, the 2.x branch doesn't initialize properly or follow 2.x convention.

https://timber.github.io/docs/v2/upgrade-guides/2.0/

@szepeviktor
Copy link
Contributor

Thank you!

Please update PR title to Use v2 API

@naderabbara naderabbara changed the title 2.x Use v2 API Jul 21, 2022
@naderabbara
Copy link
Contributor Author

Thank you!

Please update PR title to Use v2 API

No problem, done!

@jarednova
Copy link
Member

This looks right to me, @gchtr does this conform to preferred style?

@naderabbara
Copy link
Contributor Author

Also merged #132 into this PR as they're sort of one in the same.

@gchtr had a chance to review?

@gchtr
Copy link
Member

gchtr commented Oct 11, 2022

@naderabbara @jarednova Looks good, thanks for these updates!

@szepeviktor szepeviktor mentioned this pull request Oct 11, 2022
@gchtr gchtr merged commit b1946c5 into timber:2.x Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants