2.x Revert theme subfolder #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having template files in a subfolder can lead to unexpected consequences, as we can see in timber/timber#2458. There may be other effects. Working around them is more tedious than the benefits a subfolder brings.
|
Oh nooo! I've even developed a solution for non-Composer installation (ZIP upload). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #103, all template files were moved into a subfolder for a better file structure. However, this leads to consequences like wrong paths for images (see timber/timber#2453).
We could fix these issues and work around it, but is it worth it? I don’t think the benefit of having a nicer file structure is bigger than having to manage various issues, because the file structure doesn’t follow the WordPress standard.
If people still wanted to use that structure, we could add filters in the appropriate places in Timber core that would allow them to fix these issues themselves. But we probably shouldn’t handle this case in Timber core itself.
This pull request reverts the changes in #103 and moves the theme files back to the root folder.