2.x Move StarterSite class to src folder
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
reviewed
Jul 31, 2023
gchtr
changed the title
StarterSite class to src folder
jarednova
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a better code structure, we can add
StarterSiteto its own class in a src folder. This is also the approach you would use to autoload classes using Composer.I didn’t add the
autoloadentry to composer.json itself, because (as @szepeviktor noted in #143 (review)) developers would best use a namespaced approach. But if we defined a default namespace, we could end up with a lot of themes not updating from the default namespace, which is not better.This pull request also moves the
Timber::$autoescape = falseto that class, calling it the way we advise in Timber 2.0.