Adding count property to queryiterator #1032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #837
Reviewer: @jarednova
Issue
If you have a
Timber\QueryIterator
object, there is no way to get the total posts returned, for example of a search results page with the defaultposts
object in context.Solution
Add a method to return the private
_query.post_count
propertyImpact
No impact
Usage
{{ QueryIteratorObject.post_count }}
Considerations
There may be other properties that would be useful to expose. Also I am not sure on the reason behind returning a
QueryIterator
rather than a collection ofTimber\Post
s, you could then do{{ posts | length }}
to get the total postsTesting
None