Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to resize | retina chaining #1672

Merged
merged 10 commits into from
Sep 12, 2018
Merged

Remove reference to resize | retina chaining #1672

merged 10 commits into from
Sep 12, 2018

Conversation

zackphilipps
Copy link
Contributor

Ticket: #404

Issue

Docs state that you can chain the resize and retina filters, but there's a bug that makes this currently unusable.

Solution

Remove this section of the docs.

Impact

Nonezo.

Usage Changes

Nonezo.

Considerations

Fixing the bug would be a better solution, but not sure what's involved there.

Testing

Nonezo.

@codecov
Copy link

codecov bot commented Feb 26, 2018

Codecov Report

Merging #1672 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1672      +/-   ##
============================================
- Coverage     94.83%   94.77%   -0.06%     
+ Complexity     1527     1511      -16     
============================================
  Files            48       48              
  Lines          3585     3563      -22     
============================================
- Hits           3400     3377      -23     
- Misses          185      186       +1
Impacted Files Coverage Δ Complexity Δ
lib/Twig.php 97.47% <0%> (-1.97%) 94% <0%> (+11%)
lib/Menu.php 88.37% <0%> (-1.92%) 44% <0%> (-7%)
lib/Image/Operation/Retina.php 91.3% <0%> (-0.7%) 6% <0%> (-1%)
lib/Image/Operation/ToJpg.php 96% <0%> (-0.3%) 6% <0%> (-1%)
lib/Post.php 95.05% <0%> (-0.11%) 227% <0%> (-9%)
lib/Image/Operation/Resize.php 98.05% <0%> (-0.04%) 32% <0%> (-1%)
lib/Theme.php 100% <0%> (ø) 7% <0%> (ø) ⬇️
lib/URLHelper.php 100% <0%> (ø) 78% <0%> (-1%) ⬇️
lib/Image/Operation/Letterbox.php 100% <0%> (ø) 11% <0%> (-1%) ⬇️
lib/ImageHelper.php 97.23% <0%> (+1.04%) 80% <0%> (-5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112e0b9...dbda575. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 26, 2018

Coverage Status

Coverage remained the same at 94.159% when pulling 98dfaf5 on zackphilipps:master into 8b2b068 on timber:master.

@gchtr gchtr self-assigned this Mar 3, 2018
@gchtr gchtr changed the base branch from master to 2.x September 12, 2018 09:01
@gchtr gchtr merged commit 81e4d43 into timber:2.x Sep 12, 2018
@gchtr
Copy link
Member

gchtr commented Sep 12, 2018

Thanks @zackphilipps for this pull request! And sorry it took so long to merge this in.

We should definitely not have documentation about a feature that doesn’t work yet! Handling images in Timber is something that still needs a lot of work.

I accidentally mixed in some other commits into this pull request, sorry about that!

@zackphilipps
Copy link
Contributor Author

@gchtr thanks, and no worries! cheers.

@gchtr gchtr mentioned this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants