Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump upstatement/routes package to 0.5 #1946

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Bump upstatement/routes package to 0.5 #1946

merged 1 commit into from
Mar 8, 2019

Conversation

seanstickle
Copy link
Contributor

@seanstickle seanstickle commented Mar 7, 2019

Issue

The current version of timber requires upstatement/routes r0.4. This version of routes requires an older version of altorouter, and that version of altorouter does a reset of $_REQUEST that causes some problems with other plugins (e.g. https://twitter.com/seanstickle/status/1103481154785693697).

Solution

@jarednova over at Upstatement released 0.5 of upstatement/routes today that updates the version of altorouter that is used. This PR just bumps the version of upstatement/routes to 0.5.

Impact

No expected impact. The changes to upstatement/routes since 0.4 have been minor -- just bumping the version of altorouter and adding a priority param (Upstatement/routes@5040174).

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #1946 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1946   +/-   ##
=========================================
  Coverage     95.04%   95.04%           
  Complexity     1556     1556           
=========================================
  Files            48       48           
  Lines          3672     3672           
=========================================
  Hits           3490     3490           
  Misses          182      182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd57f2b...9d8787a. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.324% when pulling 9d8787a on seanstickle:master into dd57f2b on timber:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.324% when pulling 9d8787a on seanstickle:master into dd57f2b on timber:master.

@jarednova
Copy link
Member

Yup, let's do it. Thanks for seeing this through @seanstickle !

@jarednova jarednova merged commit e663dee into timber:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants