upgrade Loader to use renamed Twig\TwigFunction #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `WP_DEBUG` is disabled, a Fatal Error will be thrown: "Class 'Timber\Twig_Function' not found". This just fixes the name so we're using the right class.
|
d'oh! Great find. In terms of testing: unfortunately, there's no easy way to enable/disable PHP constants once they've been set. I banged my head against a wall for awhile trying to get things going with PECL / Runkit at one point. But after the bleeding stopped, I was no closer. I'll let @gchtr take a formal look at this, but my vote is to fix the problem and make testing against |
gchtr
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Looks good! 馃憤
@jarednova I鈥檒l leave it to you to create an issue for a future todo about testing with WP_DEBUG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
WP_DEBUGis disabled, a Fatal Error will be thrown: "Class 'Timber\Twig_Function' not found". This just fixes the name so we're using the right class.Issue
I'm just starting to integrate our budding 2.x alpha on a real project, and this is the first thing I ran into. Looks like a code path that's probably not covered by the tests, but I don't have time to figure out how to test using different constants. But the fix is about as simple as it gets.
Solution
usethe correctTwig\TwigFunctionclass within Loader.Impact
The thing will work now! 馃槃
Usage Changes
None
Considerations
How can we test this reliably? Is it worth it?
Testing
None for now.