Fix the thumbnail()
method return type
#2463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The returned value of the
Post::thumbnail()
method is considered to be\Timber\Timber\Image
as we already are in theTimber
namespace andTimber\Image
is missing a leading\
. This is making tools such as PHPStan to fail.Solution
The solution is to use the same type as the
Post::get_thumbnail()
method, which is directly using theImage
class from the current namespace.Impact
It will improve compatibility with static analysis tools such as PHPStan.
Testing
Nothing to update (I think).