Fix a test failing with 2.x + Multisite #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1617
Issue
A new test with #2478 causes issues in 2.x because Image::wp_upload_dir() is removed.
Solution
Test against the generated URL rather than what's stored in this (no longer existent) variable
Impact
Just a change to a test, no functional code. I don't think the test covers anything "real" at this point since that var isn't being cached; but didn't want to toss the test just in case.
Usage Changes
None
Considerations
As I type this, I realize I should confirm against resizing too