Add webp support to letterbox filter #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednova
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: None
Issue
The letterbox class does not support webp images.
Solution
Add support for webp images
Impact
The 'imagewebp' & 'imagecreatefromwebp' functions were added in PHP 5.4. The Timber Wordpress page reports a minimum PHP version of 5.6, however, the current composer.json shows 5.3. I'm not sure if the composer.json is out of date or not.
Usage Changes
There should be none
Considerations
See Impact
Testing
There doesn't seem to be specific tests for the different extensions.