Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer/installers from v1 to v2 #2544

Merged

Conversation

adamtomat
Copy link
Contributor

Ticket: #2533

Issue

Bedrock (from Roots) recently upgraded to composer/installers v2 and it makes it very hard to use Timber with Bedrock without also upgrading Timber's dependency.

Solution

Upgrade Timber's "composer/installers" dependency to match Bedrock's (roots/bedrock@43e2a97)

The upstatement/routes package also needs updating before this issue can be resolved.

Impact

Shouldn't have much impact. Anyone who still has a dependency on v1 of composer/installers would be able to use a previously tagged version of Timber if needed.

Considerations

The alternative would be to add support for v1 or v2 like so:
"composer/installers": "~1.0|^2.0"

@coveralls
Copy link

coveralls commented Feb 21, 2022

Coverage Status

Coverage remained the same at 89.774% when pulling 0160425 on adamtomat:2.x-update-composer-installers-dependency into 60d0b31 on timber:2.x.

Copy link
Member

@gchtr gchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from me. We can merge this in as soon as we fixed the issues with the automated tests.

@gchtr gchtr added the 2.0 label Feb 24, 2022
@jarednova
Copy link
Member

Automated tests are now clear — thanks for clearing through that @gchtr.

And thanks as always @adamtomat for this and #2543 to keep us up to date with these Composer dependencies!

@jarednova jarednova merged commit 78f944e into timber:2.x Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants