Allow the Timber\PostPreview::read_more to accept a boolean value #2578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The Timber\PostPreview::read_more docs say:
But
Timber\PostPreview::read_more
doesn't actually accept a boolean value, it only accepts astring
value type. 馃槵Solution
Add
bool
to thereadmore
docblock.Impact
Minimal to none?
Usage Changes
No usage changes, to my knowlege.
Considerations
None come to mind.
Testing
I did not add tests. Not sure how to do so.