Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the Timber\PostPreview::read_more to accept a boolean value #2578

Merged
merged 1 commit into from Feb 24, 2024

Conversation

gerardo-rodriguez
Copy link

Issue

The Timber\PostPreview::read_more docs say:

Set this to false to not add a "Read More" link.

But Timber\PostPreview::read_more doesn't actually accept a boolean value, it only accepts a string value type. 馃槵

Screen Shot 2022-04-29 at 11 37 53 AM

Solution

Add bool to the readmore docblock.

Impact

Minimal to none?

Usage Changes

No usage changes, to my knowlege.

Considerations

None come to mind.

Testing

I did not add tests. Not sure how to do so.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.294% when pulling 85ddda4 on gerardo-rodriguez:feature/readmore-allow-bool into e1460c0 on timber:master.

@jarednova jarednova added the 1.x label Jun 24, 2022
@Levdbas Levdbas added 2.0 and removed 1.x labels Dec 13, 2023
@Levdbas Levdbas added this to the 2.0.1 milestone Dec 14, 2023
@Levdbas Levdbas modified the milestones: 2.0.1, 2.1.0 Feb 1, 2024
Copy link
Member

@nlemoine nlemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @gerardo-rodriguez, thanks for fixing the docblock!

@timber/rangers Note for future releases, this should be revised with actual types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants