Setup on attachment

[xavivars]

Ticket:
Fixes: #2607

Issue

Caption on images is empty, and not intitialized.

Solution

Implements Attachment::build method that will be used in PostFactory so caption is defined.

Impact

It's really a bugfix.

Considerations

Not 100% sure this is the way that it's meant to be implemented. An alternative (that would break backwards compatibility) would be to just remove the field, and document it so post_excerpt is used instead.

Testing

I didn't add any test.

[coveralls]

Coverage increased (+0.01%) to 87.997% when pulling 034f247 on xavivars:2.x-initialize-caption into 1500e48 on timber:2.x.

[gchtr]

Hey @xavivars, thanks for reporting the issue and making this pull request. This is really something we missed when working on the factories as well as splitting Timber\Image into the two separate Timber\Image and Timber\Attachment classes. Nice catch!

Not 100% sure this is the way that it's meant to be implemented. An alternative (that would break backwards compatibility) would be to just remove the field, and document it so post_excerpt is used instead.

I would keep {{ image.caption }} and not document that it’s saved in the post excerpt. I even think we should use a caption() method instead of the property and added a pull request that iterates on your pull request in #2612.