Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x Add missing query() method to Timber\PostQuery #2613

Merged
merged 4 commits into from Jul 26, 2022
Merged

Conversation

gchtr
Copy link
Member

@gchtr gchtr commented Jul 20, 2022

Ticket:

Issue

The get_query() method didn’t make it over to 2.x.

Solution

This pull request:

  • Adds the missing method and renames from get_query() to query() to match the naming convention.
  • Deprecates the get_query() method.
  • Adds a test.
  • Updates the Upgrade Guide.

Impact and Usage Changes

Mentioned in the Upgrade Guide.

Considerations

Testing

Yes.

src/PostQuery.php Outdated Show resolved Hide resolved
@gchtr gchtr requested review from nlemoine and removed request for jarednova July 26, 2022 06:06
@gchtr gchtr merged commit bd6b9f6 into 2.x Jul 26, 2022
@gchtr gchtr deleted the 2.x-missing-query-method branch July 26, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants