2.x Fix tests in #2614 #2621
Merged
2.x Fix tests in #2614 #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a custom timber-test.php file to add the translations that can be read by the wp i18n command and saved in test/languages/timber-test.pot. In the tests, we then use the hardcoded "timber-test" text domain and load it using load_textdomain().
|
@nlemoine Could you look at the issue where |
2.x update tests fix indentation
nlemoine
approved these changes
Jul 29, 2022
|
@nlemoine Ooops, sorry for re-requesting the review, you already gave the good to go… I’m merging this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #2614
Issue
There are some testing issues in #2614.
Solution
This pull request:
wp i18ncommand and be saved in test/languages/timber-test.pot. In the tests, we then use the hardcoded "timber-test" text domain and load it usingload_textdomain()instead of somehow loading the translations for the Twenty Fiften theme and adding custom translations there.Impact
None.
Usage Changes
None.
Considerations
I ran into some issues when using
composer cs:fix. It just added whitespace to the test files and added more whitespace if I rancomposer cs:fixmultiple times.Testing
Yes.