Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GitHub pull request template #2641

Merged
merged 1 commit into from Mar 2, 2023
Merged

Improve GitHub pull request template #2641

merged 1 commit into from Mar 2, 2023

Conversation

gchtr
Copy link
Member

@gchtr gchtr commented Sep 15, 2022

Let’s update the GitHub pull request template and use a notation for related tickets. This will automatically enhance the tickets with the proper ticket / pull request titles and the status of the related tickets. This that can be seen in the following screenshot:

@gchtr gchtr requested a review from jarednova October 9, 2022 10:04
@gchtr gchtr added the Ready for Review Ready for a contrib to take a look at and review/merge label Dec 30, 2022
@nlemoine nlemoine self-requested a review February 28, 2023 20:00
nlemoine
nlemoine approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@nlemoine nlemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice improvement!

We could enhance issue template as well. Did you know you can make issue form template? I always wanted to setup that up but never had a chance.

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms

This could really improve feedback quality.

@gchtr gchtr mentioned this pull request Mar 2, 2023
Merged
@gchtr
Copy link
Member Author

gchtr commented Mar 2, 2023

@nlemoine I didn’t know that exists. Wonderful, let’s try it out! 🙌 See #2711.

@gchtr gchtr merged commit 7c11f93 into master Mar 2, 2023
@gchtr gchtr deleted the pull-request-template branch March 2, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlemoine nlemoine nlemoine approved these changes

@jarednova jarednova Awaiting requested review from jarednova

Assignees
No one assigned
Labels
Ready for Review Ready for a contrib to take a look at and review/merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gchtr @nlemoine