2.x Remove unneeded Timber\Image::is_image() method

[gchtr]

Related:

• 2.x Fix PHPStan issues on level 0 #2659

Issue

While working on #2659, I found that we probably don’t need the Timber\Image::is_image() method anymore. We now have an is_image() function in the PostFactory:

timber/src/Factory/PostFactory.php

Line 173 in 8545e2e

protected function is_image(WP_Post $post)

The logic is that if you use Timber::get_post(), you will only get an instance of Timber\Image, if it’s an image attachment and a Timber\Attachment instance if it’s a non-image attachment.

The Timber\Image::is_image() method is used to check whether a certain function can be used, because it only makes sense for images. But now, if we’re inside Timber\Image, we can assume that we have an image.

Solution

Remove the method and where it’s used.

Impact

This is a breaking change, hence the note in the Upgrade Guide.

Usage Changes

Instead of using Timber\Image::is_image(), we would have to use:

if ( $post instanceof Timber\Image ) {

}

Considerations

Using instanceof doesn’t work so well in Twig. Should there be an is_image() function in Timber\Post?

public function is_image()
{
	return $this instanceof Timber\Image;
}

We could also just remove the is_image() checks in Timber\Image an keep the method.

Any opinions?

Testing

Covered through existing tests.

[nlemoine]

This looks good to me!

[gchtr]

Thanks for the feedback here, everyone!