2.x Fix Menu theme locations array to enforce string or integers

[mcaskill]

Issue

With Timber v2 , WPML, and PHP 8, if any nav menu location happens to be null, this warning occurs:

Warning: array_flip(): Can only flip string and integer values, entry skipped in vendor/timber/timber/src/Menu.php on line 255

This is similar to issue #2576 where the warning was with MenuFactory::get_menu_location().

Solution

The solution is to apply the same fix made to MenuFactory; filter the nav menu locations array to enforce strings or integers.

Testing

The TestTimberMenu::testThemeLocationProperty() method was updated to match TestMenuFactory::testGetMenuLocation().

[coveralls]

Coverage: 88.685% (+0.003%) from 88.683% when pulling 781b8b8 on mcaskill:2.x-fix-menu-theme-locations into c96b9f8 on timber:2.x.

[gchtr]

Thanks for this fix, @mcaskill! 👍