Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken links in documentation #2743

Merged
merged 7 commits into from
May 20, 2023
Merged

Conversation

Levdbas
Copy link
Member

@Levdbas Levdbas commented May 18, 2023

Ticket: #2742

Issue

Link checker action found 22 broken links in the documentation.

Solution

  • Updated internal links: 5b8292c
  • Updated 2.0 guide: ff6d967
  • Added alternative for cdn guide: ed2abaf and 23bbe8a
  • Removed Gulp guide from translation since it is not available anymore: 4c80846
  • Updated template hierarchy section with some explanation and an alternative link : 225fb10
  • Updated integration links and text because we only have one integration guide at this time: ad5b59f

Impact

With the removal of the Gulp translation guide we lose one method of translation.

@Levdbas Levdbas requested a review from gchtr as a code owner May 18, 2023 06:23
@Levdbas Levdbas changed the title Docs link update Update broken links in documentation May 18, 2023
@Levdbas Levdbas mentioned this pull request May 18, 2023
30 tasks
@coveralls
Copy link

Coverage Status

Coverage: 88.599%. Remained the same when pulling ad5b59f on Levdbas:docs-link-update into b32340d on timber:2.x.

@gchtr gchtr added the 2.0 label May 20, 2023
Copy link
Member

@gchtr gchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on this and getting those links working again, @Levdbas.

It’s unfortunate that we lose one of the free versions for translation, but maybe in the future it will be possible with the wp i18n command.

@gchtr gchtr merged commit 9d66ca8 into timber:2.x May 20, 2023
25 checks passed
@Levdbas Levdbas deleted the docs-link-update branch May 20, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants