Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update property and method docblocks in Theme.php. #2744

Merged

Conversation

Levdbas
Copy link
Member

@Levdbas Levdbas commented May 20, 2023

Related:

Issue

When looking through the old issues, I found this issue which I ran into a long time ago as well. So I tried to clear up the docblocks.

Solution

The changes on rule 75 and 137 are leading in this PR. The now reflect more what to expect of the property/method.

Other changes while at it:

  • The changes to rule 69, 94, 116 are to give a consistent example of theme slugs.
  • 113 fixes a typo.
  • 146 removes a double space and adds a capital letter.

Impact

Hopefully a better overall understanding of the Theme class.

@Levdbas Levdbas requested review from gchtr and removed request for gchtr May 20, 2023 12:57
@Levdbas Levdbas changed the title Update property and method docblocks of theme. Update property and method docblocks in Theme.php. May 20, 2023
@coveralls
Copy link

Coverage Status

Coverage: 88.599%. Remained the same when pulling 7f30f3f on 1313-breaking-change-to-timberthemes-uri-for-child-themes into b32340d on 2.x.

@gchtr gchtr added the 2.0 label May 26, 2023
Copy link
Member

@gchtr gchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Levdbas

Descriptions like these can make a big difference in understanding what a property or method should do 👍

@gchtr gchtr merged commit 70bff7b into 2.x May 26, 2023
51 of 52 checks passed
@gchtr gchtr deleted the 1313-breaking-change-to-timberthemes-uri-for-child-themes branch May 26, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants