Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @api tag to Helper #2746

Merged
merged 1 commit into from May 26, 2023
Merged

Add @api tag to Helper #2746

merged 1 commit into from May 26, 2023

Conversation

Levdbas
Copy link
Member

@Levdbas Levdbas commented May 21, 2023

Issue

Helper.php class is not in the current V2 docs. This seems to be caused by the missing @api tag. This also causes one of the missing links in #2745

Solution

Add the @api tag and deploy the new docs.

Impact

More docs!

@coveralls
Copy link

Coverage Status

Coverage: 88.623%. Remained the same when pulling 89d602f on 2.x-helper-class-api-tag into b71a6bd on 2.x.

@gchtr gchtr added the 2.0 label May 23, 2023
Copy link
Member

@nlemoine nlemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

Copy link
Member

@gchtr gchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for this one!

@gchtr gchtr merged commit 346976e into 2.x May 26, 2023
52 checks passed
@gchtr gchtr deleted the 2.x-helper-class-api-tag branch May 26, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants