2.x Remove unused param from Timber\Term::build()
#2754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue
There is an unused property in
Timber\Term::build()
. The$_options
parameter was introduced in 21445a1, where it was still needed. At that time,Timber\Menu
still extendedTimber\Term
. SoTimber\Term::build()
had to use that optional parameter to be compatible.Now,
Timber\Term
only extendsTimber\CoreEntity
.Solution
We can safely remove that unused parameter.
Impact
None.
Usage Changes
None.
Considerations
None.
Testing
None needed.