Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x Remove unused param from Timber\Term::build() #2754

Merged
merged 1 commit into from May 26, 2023
Merged

Conversation

gchtr
Copy link
Member

@gchtr gchtr commented May 26, 2023

Related:

Issue

There is an unused property in Timber\Term::build(). The $_options parameter was introduced in 21445a1, where it was still needed. At that time, Timber\Menu still extended Timber\Term. So Timber\Term::build() had to use that optional parameter to be compatible.

Now, Timber\Term only extends Timber\CoreEntity.

Solution

We can safely remove that unused parameter.

Impact

None.

Usage Changes

None.

Considerations

None.

Testing

None needed.

@gchtr gchtr added the 2.0 label May 26, 2023
@gchtr gchtr requested a review from Levdbas May 26, 2023 15:32
@gchtr gchtr mentioned this pull request May 26, 2023
1 task
Copy link
Member

@nlemoine nlemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! :)

@Levdbas Levdbas merged commit 258d691 into 2.x May 26, 2023
52 checks passed
@gchtr gchtr deleted the 2.x-term-build-params branch September 21, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants