Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x Fix some small issues in Getting Started docs #2761

Merged
merged 1 commit into from May 31, 2023

Conversation

gchtr
Copy link
Member

@gchtr gchtr commented May 31, 2023

Related:

Issue

I initially wanted to add test for the different code snippets. But this seems a little too tedious. Most of the functionality used there is already tested elsewhere.

Still, I found some details to fix.

Solution

Fix some smaller issues.

Impact

None.

Usage Changes

None.

Considerations

None.

Testing

No.

Copy link
Member

@Levdbas Levdbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I never knew about the no_found_rows optimization to be honest. I learned something!

@Levdbas Levdbas merged commit 9f37aa8 into 2.x May 31, 2023
43 of 52 checks passed
@Levdbas Levdbas deleted the 2.x-docs-getting-started branch May 31, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants