2.x Fix implicit conversion from float to int

[gchtr]

Related:

• [BUG] Deprecation Notice implicit conversion from float to int in ImageDimensions.php #2772

Issue

We require dimensions to be int, but SVG might have float dimensions.

Solution

Convert to int.

Impact

No deprecation notice.

Usage Changes

None.

Considerations

Should we round the values before typecasting them to int using round()?

I think we also have to consider whether it might be important to get SVG dimensions as floats. For using the dimensions as width and height attributes in HTML, it has to be an integer value.

But maybe there’s a use case where you’ll want to access SVG dimensions as floats. In that case, we might somehow have to give access to ImageDimensions::get_dimensions_svg(), which is protected at the moment:

timber/src/ImageDimensions.php

Line 164 in a23d781

protected function get_dimensions_svg($svg)

Testing

No.

[Levdbas]

I think there is no need to disclose the original values via get_dimensions_svg() since having SVG widths and heights as floats are bad to begin with in my experience. I exerienced a lot of issues with for example hairlines when scaling a svg down with a large number after the decimal as width/height. And I think rounding the numbers is the way to go before typecasting them.

[Levdbas]

It seems like the tests asserts that the SVG viewbox width of 530.91 is rounded down to 530, instead of up. In my opinion the current round function is what we would like.

We could change the testing value to 531 or the actual svg viewbox width 529.91, which gets then rounded up to 530?

But correct me if I am wrong @gchtr !

[gchtr]

@Levdbas Thanks for the hint! I didn’t runt the tests locally, so I missed the rounded numbers issue.