Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x Fix MariaDB in automatic tests #2776

Merged
merged 3 commits into from Jul 24, 2023
Merged

2.x Fix MariaDB in automatic tests #2776

merged 3 commits into from Jul 24, 2023

Conversation

gchtr
Copy link
Member

@gchtr gchtr commented Jul 21, 2023

Issue

Tests don’t run after automatic update to MariaDB v11.

Solution

As a first measure: downgrade to MariaDB v10.

Then, we can start to find out what went wrong. I read the Upgrade Guide for the 11 release (https://mariadb.com/kb/en/upgrading-from-mariadb-10-11-to-mariadb-11-0/), but I don’t know MariaDB or MySQL well enough to see what we would need to change.

@nlemoine Do you know what to do here?

Impact

Fixes automatic tests.

Usage Changes

None.

Considerations

None.

@Levdbas
Copy link
Member

Levdbas commented Jul 21, 2023

This is what we might need to fix this for MariaDB 11: See this PR.
I think we need to change the --health-cmd line in our test and maybe set those two constants as well? @gchtr

This change is needed because of:

11.0, unlike previous version, no longer includes mysql named compatible executable symlinks inside the container.

@gchtr
Copy link
Member Author

gchtr commented Jul 24, 2023

Cool, thanks for finding the solution. In the thread of that PR, I found a link to a blog post that contains even a simpler solution: https://mariadb.org/mariadb-server-docker-official-images-healthcheck-without-mysqladmin/.

Looks like the tests are not stuck on the MySQL health check anymore. So I’m merging this in.

@gchtr gchtr merged commit 3bc2f7b into 2.x Jul 24, 2023
16 of 50 checks passed
@gchtr gchtr deleted the 2.x-fix-test-actions branch July 24, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants