add check to image create functions #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking this on! I’m not sure about the best approach to handle this. Error handling in general is still an open issue for the future: #2210. Until we didn’t define how we should handle errors, I think we should silently return without adding a message to the error log. |
…geistruecolor-argument-1-$image-must-be-of-type-gdimage-null-given-error # Conflicts: # src/Image/Operation/ToJpg.php # src/Image/Operation/ToWebp.php
nlemoine
reviewed
Jul 28, 2023
Co-authored-by: Nicolas Lemoine <nico.lemoine@gmail.com>
szepeviktor
approved these changes
Jul 28, 2023
gchtr
approved these changes
Jul 31, 2023
gchtr
deleted the
2771-bug-towebp-causes-uncaught-typeerror-imageistruecolor-argument-1-$image-must-be-of-type-gdimage-null-given-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue
The imagecreatefrom functions should return false or an instance of GDimage. In the related issue null is returned, which is strange. But I think it is save to add an additional check to see whether we should postpone the image operation when the result of the function is null or false.
Solution
Check if $input has a value before continuing.
Impact
Better error handling.
Usage Changes
None
Considerations
There is a bit of overlap in these two classes. We might want to take a closer look at them in the future to make them more DRY.
Testing
no.