-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x #2767 Optimize URLHelper methods is_local
and is_external
#2782
Merged
Commits on Jun 8, 2023
-
Fix URLHelper methods is_local and is_external
Resolves #2766 Changed: - Method `is_local()` to find occurrence on URL's hostname instead of the entire URL. - Method `is_external()` to use `is_local()`.
Configuration menu - View commit details
-
Copy full SHA for df93be2 - Browse repository at this point
Copy the full SHA df93be2View commit details -
Replace URLHelper is_local strstr with strict comparison
This will resolve issues where the current host is a subdomain or substring of the URL's host.
Configuration menu - View commit details
-
Copy full SHA for 6bde71e - Browse repository at this point
Copy the full SHA 6bde71eView commit details
Commits on Jul 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1b98847 - Browse repository at this point
Copy the full SHA 1b98847View commit details -
Configuration menu - View commit details
-
Copy full SHA for f73f5a2 - Browse repository at this point
Copy the full SHA f73f5a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9324d64 - Browse repository at this point
Copy the full SHA 9324d64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fee077 - Browse repository at this point
Copy the full SHA 8fee077View commit details -
Configuration menu - View commit details
-
Copy full SHA for ecc59ac - Browse repository at this point
Copy the full SHA ecc59acView commit details -
Replace strstr in URLHelper is_external method
Replaced with `str_starts_with()` to check for the double slash and `parse_url()` to check for the scheme. This will resolve issues where `http` or `//` might be a substring of the URL's path.
Configuration menu - View commit details
-
Copy full SHA for 0cd8e04 - Browse repository at this point
Copy the full SHA 0cd8e04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83f66d3 - Browse repository at this point
Copy the full SHA 83f66d3View commit details -
Improve URLHelper is_local method
if `wp_parse_url()` fails to extract or does not find a host name in the given URL parameter, presume that the parameter might be a host name itself, such as `example.org` (see unit test).
Configuration menu - View commit details
-
Copy full SHA for 7c5e0d7 - Browse repository at this point
Copy the full SHA 7c5e0d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c61e97 - Browse repository at this point
Copy the full SHA 8c61e97View commit details
Commits on Jul 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8d06cf8 - Browse repository at this point
Copy the full SHA 8d06cf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51214af - Browse repository at this point
Copy the full SHA 51214afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46b5a28 - Browse repository at this point
Copy the full SHA 46b5a28View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.