Typo: Changing functions section references $filters instead of $functions #2799
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, I didn’t want to close this! Sorry for that, especially because it’s your first pull request! It happened because you made that pull request against the |
gchtr
approved these changes
Sep 21, 2023
|
Alright, I fixed it by readding the branch and the basing it on the Thanks a lot @niclm for taking the time to create your first pull request 🎉. Details like these matter a lot! |
|
🥳 no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Typo in the Changing functions section of Extending Twig docs. References
$filtersinstead of$functions