Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extimg-patch #2825

Merged
merged 3 commits into from Oct 24, 2023
Merged

Extimg-patch #2825

merged 3 commits into from Oct 24, 2023

Conversation

nlemoine
Copy link
Member

Related:

  • Ticket 1
  • Ticket 2

Issue

Solution

Impact

Usage Changes

Considerations

Testing

@nlemoine nlemoine mentioned this pull request Oct 20, 2023
Merged
@jrathert
Copy link
Contributor

jrathert commented Oct 20, 2023 •
edited

@nlemoine, all - I am not too happy with this "null-handling" - please see my comments in the original patch I submitted: #2818 (comment) Fine with it 😉

@coveralls
Copy link

Coverage Status

coverage: 88.515% (-0.007%) from 88.522% when pulling 7315b6b on extimg-patch into 9054d66 on 2.x.

@nlemoine nlemoine merged commit 605b266 into 2.x Oct 24, 2023
24 of 30 checks passed
@nlemoine nlemoine deleted the extimg-patch branch October 24, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchtr gchtr gchtr approved these changes

@jarednova jarednova Awaiting requested review from jarednova jarednova is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nlemoine @jrathert @coveralls @gchtr