Fix dynamic properties warnings

[trsteel88]

Related:

• Workaround for PHP 8.2 dynamic property deprecation warnings in Timber 1.x #2793

Issue

This removes the warnings that flood a site on newer versions of PHP

Solution

Implement the #[\AllowDynamicProperties] attribute. This is not a BC break as older versions of PHP would see this as a comment and ignore it.

Impact

None.

[gchtr]

Thanks for the pull request!

In Timber 2.0, we also have #[\AllowDynamicProperties] on Timber\PostType.

timber/src/PostType.php

Line 11 in 7992eee

#[AllowDynamicProperties]

Because Timber\PostType doesn’t extend Timber\Core, I think we should add it there as well.

[trsteel88]

Good catch @gchtr. That's been updated in this PR

[trsteel88]

Any chance of getting this merged and tagged @gchtr?

[gchtr]

Any chance of getting this merged and tagged @gchtr?

Yes, working on it. Just had to fix some tests and add testing for 8.2 to confirm that all Dynamic Property Warnings in Timber are actually gone. See #2890.

[nlemoine]

all good 👍

[gchtr]

This is now released in https://github.com/timber/timber/releases/tag/1.24.0

[trsteel88]

Thanks @gchtr