feat: allow pagination object to be generated using $prefs only #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ination-from-prefs-only
|
PHPStan is right, the |
$current is a 0-based array index whereas $this->current is the page number. Using $current introduces a bug, since it clears $this->prev on page 2.
|
@nlemoine OK fixed. |
Levdbas
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
#2635
Issue
Allow pagination object to be generated using $prefs only. Currently there's a dependency on wp_query via the $paged wp_query param when checking if the previous pagination link should be rendered.
Solution
Use $current instead of $paged when checking if previous pagination link should be generated. $current is initialized using $paged but then overridden with the corresponding value in $prefs. Now we can use $prefs to wholly configure a pagination object.
Impact
No impact. Backwards compatible.
Usage Changes
None.
Considerations
None.
Testing
No tests needed.