Update ToWebp.php #2865
Merged
Update ToWebp.php #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input can be false. so add a return false
|
We recently had (and probably still have) problems with invalid JPGs breaking the page because imageistruecolor is producing a fatal error if receiving a boolean. Can this be merged ASAP please? |
Levdbas
approved these changes
Jan 28, 2024
gchtr
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Thanks and congratulations to your first pull request.
This is already fixed in Timber 2.0, but let’s backport this to 1.x.
We’d appreciate it if you’d describe the change next time you make a pull request. That’s what the pull request template is for. It takes away the burden of guessing why certain changes were made, even if they might seem obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input can be false. so add a return false
Related:
Issue
Solution
Impact
Usage Changes
Considerations
Testing