fix: unnecessary lowercasing parameters

[bitfactory-robin-martijn]

Related:

• Query params are transformed to lowercase in URLHelper::get_params() #2507

Issue

When using URLHelper::get_params(), everything is normalised to lowercase. I understand why you would do that with URLs, but in this specific instance it is about parameters. I think the author of the issue raises a valid point that case sensitive parameters are valid. The RFC only speaks of normalising the protocol and scheme: https://www.rfc-editor.org/rfc/rfc3986#page-11

Solution

I removed the strtolower. (And fixed a small typo earlier in the file)

Impact

If some code is relying on this method also turning everything into lowercase for them, that would break.

Usage Changes

Developers should put strtolower around the output if they need that.

Considerations

I realise it is a breaking change, and therefore not ideal. I am however convinced that the original solution is the actual breaking thing here.

Testing

All existing tests were already lowercase.

[Levdbas]

Thank you for taking care of this and the typo along the way @expedition-robin-martijn

[nlemoine]

Still have to figure out what this URLHelper was made for ^^

In the meantime, this is legitimate 👍