Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed variable name #2991

Merged
merged 2 commits into from
May 7, 2024
Merged

fixed variable name #2991

merged 2 commits into from
May 7, 2024

Conversation

baglio
Copy link
Contributor

@baglio baglio commented May 7, 2024

Issue

The current $block variable in the docs for the my_acf_block_render_callback does not exists, resulting in an error.

Solution

Replaced $block['name'] with $attributes['name'].

@baglio baglio requested a review from gchtr as a code owner May 7, 2024 15:46
Copy link
Member

@Levdbas Levdbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @baglio! I added one small suggestion. You can add that to if you think it's a good addition.

docs/v2/guides/gutenberg.md Outdated Show resolved Hide resolved
Co-authored-by: Erik van der Bas <erik@basedonline.nl>
@baglio
Copy link
Contributor Author

baglio commented May 7, 2024

@Levdbas of course. Did I incorporate your suggestion correctly?

@Levdbas Levdbas merged commit 54ed1e5 into timber:2.x May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unknown variable $block in my_acf_block_render_callback; wrong variable used in the docs.
2 participants