Fixing issue with tojpg not being deleted #897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #894
Issue
Some JPG files are not deleted, when they were generated through
tojpg
Twig filter that was used on a PNG file.Solution
Change generated
tojpg
files to havetojpg
in the filename.Added two more calls to
delete_generated_files
with specific regex for thetojpg
Impact
Negligibly slower
Usage
No change
Considerations
I tried combining the two calls to one, but couldn't get it to work with
glob
correctly.